-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Add proposal for path and queryParams support in Rollouts #1524
[Proposal] Add proposal for path and queryParams support in Rollouts #1524
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @lujiajing1126! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
+ Coverage 47.91% 48.94% +1.03%
==========================================
Files 162 180 +18
Lines 23491 18803 -4688
==========================================
- Hits 11256 9204 -2052
+ Misses 11014 8382 -2632
+ Partials 1221 1217 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c1e8cc4
to
c4331ab
Compare
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
c4331ab
to
b541094
Compare
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
openkruise/rollouts#205 and related PR
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews